chore: upgrade devDependencies and migrate Storybook styling addon#551
chore: upgrade devDependencies and migrate Storybook styling addon#551
Conversation
…ng with @storybook/addon-styling-webpack
| "lint": "npm run lint:css && npm run lint:js && npm run lint:json && npm run lint:sass", | ||
| "lint:css": "stylelint dist/index.css", | ||
| "lint:js": "eslint scripts/*.js src/*.js dist/*.js --max-warnings 0", | ||
| "lint:js": "eslint scripts/*.js src/*.js dist/*.js --max-warnings 0 --no-ignore", |
There was a problem hiding this comment.
What is the affect of not adding --no-ignore?
There was a problem hiding this comment.
ESLint throws an error.
There was a problem hiding this comment.
Is this due to the gitignore update to eslint-config. I wonder if we should config more like this (or is that what the plugin is actually doing?)
There was a problem hiding this comment.
I tried updating eslint-config following the docs recommendation. A couple of takeaways:
- The suggested method for handling
.gitignoreis fairly basic. It doesn’t cover the more complex use cases you'd find in a monorepo like properly resolving the.gitignorefile. The plugin handles that very well. - Also, explicitly linting a file that’s included in
.gitignorestill errors out unless the user explicitly adds the--no-ignoreflag.
For now, I think it makes sense to stick with the plugin. It’s more reliable and saves us from having to build and maintain our own solution for those edge cases.
package.json
Outdated
| "react": "19.2.3", | ||
| "react-dom": "19.2.3", | ||
| "react-is": "19.2.3", |
There was a problem hiding this comment.
I'm not sure we should be bumping anything to React v19 until the Garden dependencies open up the peer dependency range.
package.json
Outdated
| "styled-components": "6.1.19", | ||
| "stylelint": "16.26.1", | ||
| "stylelint-order": "6.0.4", | ||
| "stylelint-order": "7.0.0", |
There was a problem hiding this comment.
This should be removed entirely as it is now included as a direct dependency of @zendeskgarden/stylelint-config
3 participants
Description
This PR updates core development dependencies to their latest versions, including a major upgrade to React 19 and migration from the deprecated
@storybook/addon-stylingto@storybook/addon-styling-webpack.Details
This PR addresses these Dependabot and Renovate PRs and more:
Changes:
react,react-dom, andreact-isfrom 18.3.1 to 19.2.3@storybook/addon-styling(1.3.7) with@storybook/addon-styling-webpack(1.0.1is compatible with Storybook v8)style-loader,css-loader, andpostcss-loader. These are required to configure@storybook/addon-styling-webpack.storybook/main.jsconfiguration to use new addon with proper PostCSS loader chain@zendeskgarden/eslint-config: 44.0.1 → 47.1.0@zendeskgarden/stylelint-config: 22.0.0 → 23.0.0@zendeskgarden/svg-icons: 7.6.0 → 8.1.0@zendeskgarden/react-gridand@zendeskgarden/react-theming: 9.12.5 → 9.12.6eslint-config-prettier(9.1.2 → 10.1.8) andstylelint-order(6.0.4 → 7.0.0)@zendeskgarden/eslint-config@47.1.0ignores paths defined in.gitignore. Added--no-ignoreflag to ESLint command to ensure dist files are linted.github/dependabot.ymlwithlockfile-onlyversioning strategy to minimize conflicts with Renovate bot PRsChecklist
👌 style updates are Garden Designer approved (add the designer as a reviewer)npm start):hover,:focus-visible, etc.)?bedrock=false)