refactor: improve merge implementation quality and performance#13
Merged
Conversation
- Fix whitespace handling: trim instead of stripping all spaces to preserve values like "Hello World" and database URLs with spaces - Add better error handling: distinguish between expected (ENOENT) and unexpected errors (permissions, corruption) - Optimize performance: use Set-based lookup (O(n)) instead of .some() loop (O(n²)) - Update README.md with merge behavior documentation - Update CLAUDE.md with implementation details and development notes - Add comprehensive tests for space preservation and edge cases All 12 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #12 - Improves the merge implementation with bug fixes, performance optimizations, and better error handling.
Changes
🐛 Bug Fixes
replace(/\s/g, '')) to trimming only leading/trailing whitespace (.trim())MESSAGE=Hello World(becameHelloWorld)⚡ Performance Improvements
.some()loop with O(n) Set-based lookup.has()lookups.envfiles🛡️ Better Error Handling
ENOENTvs unexpected errors.env)📚 Documentation Updates
✅ Test Coverage
Why These Changes Matter
.envvalue with spaces gets corrupted.envfiles would experience quadratic slowdownTest Plan
.envfiles containing spaces in values.envfiles🤖 Generated with Claude Code