Allow a multi-character prefix to be given, rather than a byte value.#1
Allow a multi-character prefix to be given, rather than a byte value.#1ianmacd wants to merge 1 commit intozeokku:mainfrom
Conversation
|
Thank you for the contribution, but you misunderstood the program a little 😅 It will look for the specified byte, which is repeated, meaning it will search this way starting from If you want to add your functionality, it'd be great if you implemented a check against uint8 buffer here |
|
But honestly this generator was written for fun. And for a serious approach it needs to be rewritten in C instead. |
I didn't misunderstand how the program works. I just thought it would be more useful to be able to specify a prefix, rather than a single repeated byte. We're talking about vanity here, after all. 😉 |
Yes, but it won't be run very often by any one user, so the unserious approach is a fair one, I think. It also allows a good amount of code reuse from Session. |
In this case, please consider implementing this as an additional mode, rather than replacing the current one, as they have different applications. And regarding C implementation, it would be even more convenient for users if there were pre-built binary releases than dealing with JS as now. |
For greater flexibility, it would be nice to be able to specify a character prefix of arbitrary length, rather than a byte value.