Skip to content

Allow a multi-character prefix to be given, rather than a byte value.#1

Open
ianmacd wants to merge 1 commit intozeokku:mainfrom
ianmacd:main
Open

Allow a multi-character prefix to be given, rather than a byte value.#1
ianmacd wants to merge 1 commit intozeokku:mainfrom
ianmacd:main

Conversation

@ianmacd
Copy link
Copy Markdown

@ianmacd ianmacd commented Jan 6, 2023

For greater flexibility, it would be nice to be able to specify a character prefix of arbitrary length, rather than a byte value.

@Lutymane
Copy link
Copy Markdown
Member

Lutymane commented Jan 6, 2023

Thank you for the contribution, but you misunderstood the program a little 😅 It will look for the specified byte, which is repeated, meaning it will search this way starting from 55.... and then 5555.... -> 555555... and so on. Similar to finding as much 0s as possible for an Ethereum address.

If you want to add your functionality, it'd be great if you implemented a check against uint8 buffer here
https://github.com/zeokku/session-vanity-generator/blob/main/src/index.ts#L74

@Lutymane
Copy link
Copy Markdown
Member

Lutymane commented Jan 6, 2023

But honestly this generator was written for fun. And for a serious approach it needs to be rewritten in C instead.

@ianmacd
Copy link
Copy Markdown
Author

ianmacd commented Jan 6, 2023

Thank you for the contribution, but you misunderstood the program a little 😅 It will look for the specified byte, which is repeated, meaning it will search this way starting from 55.... and then 5555.... -> 555555... and so on. Similar to finding as much 0s as possible for an Ethereum address.

I didn't misunderstand how the program works. I just thought it would be more useful to be able to specify a prefix, rather than a single repeated byte. We're talking about vanity here, after all. 😉

@ianmacd
Copy link
Copy Markdown
Author

ianmacd commented Jan 6, 2023

But honestly this generator was written for fun. And for a serious approach it needs to be rewritten in C instead.

Yes, but it won't be run very often by any one user, so the unserious approach is a fair one, I think. It also allows a good amount of code reuse from Session.

@Lutymane
Copy link
Copy Markdown
Member

Lutymane commented Jan 7, 2023

I didn't misunderstand how the program works. I just thought it would be more useful to be able to specify a prefix, rather than a single repeated byte. We're talking about vanity here, after all. 😉

In this case, please consider implementing this as an additional mode, rather than replacing the current one, as they have different applications.

And regarding C implementation, it would be even more convenient for users if there were pre-built binary releases than dealing with JS as now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants