⚡ perf(limiter): implement resource registry pattern for list_resources_with_defaults() #238
+47
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es_with_defaults() Replace expensive Scan operation with atomic GetItem on resource registry record. Reduces RCU consumption from N (where N = total items in table) to 1 RCU. - Add SK_RESOURCES constant and sk_resources() key builder to schema.py - Update set_resource_defaults() to atomically ADD resource to registry set - Update delete_resource_defaults() to atomically DELETE resource from registry set - Replace list_resources_with_defaults() Scan with single GetItem on SYSTEM#/RESOURCES registry - Update CLAUDE.md DynamoDB Access Patterns table with resource registry entry Fixes #233 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## milestone/0.6.0 #238 +/- ##
===================================================
+ Coverage 94.52% 94.53% +0.01%
===================================================
Files 26 26
Lines 3906 3899 -7
===================================================
- Hits 3692 3686 -6
+ Misses 214 213 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 478c5a5 | Previous: 9e4a844 | Ratio |
|---|---|---|---|
tests/benchmark/test_operations.py::TestCascadeOverheadBenchmarks::test_acquire_without_cascade |
60.352737738054486 iter/sec (stddev: 0.024126451235096266) |
126.2154851237963 iter/sec (stddev: 0.00950221434029026) |
2.09 |
tests/benchmark/test_operations.py::TestConfigLookupBenchmarks::test_acquire_cold_config |
42.84766418513174 iter/sec (stddev: 0.043887948133382614) |
59.94391109829673 iter/sec (stddev: 0.014295610668191978) |
1.40 |
tests/benchmark/test_operations.py::TestConcurrentThroughputBenchmarks::test_sequential_acquisitions |
7.35860369890624 iter/sec (stddev: 0.13937538243426856) |
16.996027066502045 iter/sec (stddev: 0.009269329440738942) |
2.31 |
This comment was automatically generated by workflow using github-action-benchmark.
sodre
added
performance
Clarify that ADD and DELETE operations don't use SET prefix in DynamoDB UpdateExpression syntax. Changed "atomic SET ADD operation" to "atomic ADD operation" and "atomic SET DELETE operation" to "atomic DELETE operation". This is a documentation-only fix with no code logic changes. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented resource registry pattern to replace expensive Scan operation with atomic GetItem in
list_resources_with_defaults(). This resolves issue #233 and significantly improves performance and cost for large deployments.Changes
Performance Impact
Test Results
Files Modified
src/zae_limiter/schema.py- Added resource registry key builderssrc/zae_limiter/repository.py- Implemented atomic GetItem/SetItem for registryCLAUDE.md- Updated DynamoDB access patterns documentationFixes #233