This repository was archived by the owner on May 27, 2026. It is now read-only.
[kmac,rtl] Adds masking support for the sideload AppIntf in KMAC#242
Closed
apinise wants to merge 6 commits into
Closed
[kmac,rtl] Adds masking support for the sideload AppIntf in KMAC#242apinise wants to merge 6 commits into
apinise wants to merge 6 commits into
Conversation
apinise
force-pushed
the
eapinis/kmac-msg-masking
branch
7 times, most recently
from
c52bfb7 to
57ec4a1
Compare
apinise
changed the title
apinise
force-pushed
the
eapinis/kmac-msg-masking
branch
2 times, most recently
from
7b7377a to
92d5394
Compare
Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
apinise
force-pushed
the
eapinis/kmac-msg-masking
branch
from
92d5394 to
f624683
Compare
This commit expands the masking of KMAC to extend through the entire AppIntf into the SHA3 core. The interface now contains two message shares instead of plaintext and a second msgfifo was created to pass data into the SHA3 core. Using software config registers you can disable the internal masking and rely on the input message to be masked. Alternatively, sending the plaintext in share 0 will still work when KMAC is configured to mask internally. Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
Scoreboard will now unmask the two input shares to compute the digest. Updated coverage interface to only read from the first msgfifo during sw commands to mirror normal operations. Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
Created a coverage exclusion file for masked parameter due to digest share bits [383:256] for ACC app modes being tied to 0. Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
Reverted naming for byte_data_q to keep compatibility with keymgr, lc, and rom. Also made small changes to ACC DV so that block level tests can be run without full masking support. Signed-off-by: Evan Apinis <eapinis@zerorisc.com>
apinise
force-pushed
the
eapinis/kmac-msg-masking
branch
from
f624683 to
8d7e45a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the masking in AppIntf masking through the entirety of KMAC.
app_req_tinkmac_pkg.svnow containsdata_share0anddata_share1.kmac_app.svnow processes two shares in masking mode for the ACC connection through itsAppCfgDynamicmode. Other connections, including ROM, LC, and KeyMgr still use unmasked data path and the second share is driven to '0 in the respective block levels.kmac_msg.svhas a second msgfifo in masked mode to hold the second share before forwarding it to thesha3module. The FIFO status are tied together for error handling and fault detection.kmac_app_host_seq.svnow drives two shares to the ACC app interface when in masked mode, other interfaces remain '0.kmac_scoreboard.svwill unmask the input message to send to the DPI-C model.