perf: tighten message timeline and tidy workspace sidebar#606
Merged
Conversation
Drop the gap-3 that was forcing 12px between every message and only apply mt-3 at turn boundaries (user messages after the first), so assistants sit tight against their parent user message again. Strip per-message wrappers in TimelineMessage: the fake scroll-content slot, the interaction shim, and the duplicate container around the assistant slot are gone. The assistant branch now reuses the session-turn-assistant-content slot directly. Drop createAutoScroll from TimelineMessage entirely — it was creating a store, two effects, and a ResizeObserver per message for a scroll viewport that lives on the outer ScrollView. Also drop the now-unused MessageTransition wrapper and dead queued memo in MessageTimeline. Co-Authored-By: CoStrict <noreply@costrict.ai>
Assistant messages stamp time.created === time.completed at finalization, so completed - created is always 0. Walk backwards from each assistant to the previous message's anchor (prior assistant's completed, or the user message's created) so consecutive assistants show distinct durations instead of a shared turn value or zero. Co-Authored-By: CoStrict <noreply@costrict.ai>
Hide empty user turns reactively during SSE streaming and gate the thinking shimmer on whether the latest message is producing visible content, so it covers wait-after-send, first-token, and between-steps gaps instead of only the user turn. Co-Authored-By: CoStrict <noreply@costrict.ai>
Drop the early-out that showed thinking whenever the latest assistant message was completed, so a finished message with no renderable parts (e.g. hidden reasoning summaries) no longer hides the shimmer prematurely. Co-Authored-By: CoStrict <noreply@costrict.ai>
… create button Drop the workspace filter input and turn the create trigger into a full-width primary button with an icon and label, reusing the existing "workspace.device.createWorkspace" copy. Co-Authored-By: CoStrict <noreply@costrict.ai>
Reword the device-registration prompt to point at the home page guide and note that only online idle workspaces can be activated. Co-Authored-By: CoStrict <noreply@costrict.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan