Skip to content

feat: refactorigs#18

Merged
zhoozhoo merged 4 commits intomainfrom
feature/refactorigs
Mar 18, 2026
Merged

feat: refactorigs#18
zhoozhoo merged 4 commits intomainfrom
feature/refactorigs

Conversation

@zhoozhoo
Copy link
Owner

No description provided.

…istent format and improve clarity. Update Javadoc comments to use Markdown-style formatting for better readability. This includes changes in OpenTelemetryConfiguration, R2dbcConverters, validation classes, and various test classes.
…ions and clarifying data shapes for API testing resources.
…e services

- Removed obsolete Jackson and R2DBC configuration classes from loads-service and rifles-service.
- Introduced a centralized GlobalExceptionHandler for consistent exception handling across all reactive services.
- Added auto-configuration classes for GlobalExceptionHandler, R2DBC, and Validation to streamline setup.
- Implemented custom validation for JSR-385 Quantity types with appropriate error messages.
- Enhanced unit tests for GlobalExceptionHandler to cover various exception scenarios and ensure proper HTTP responses.
- Updated shared security configurations to include WebFlux support for authenticated user extraction.
- Improved dependency management in shared pom.xml for optional libraries related to validation and security.
@zhoozhoo zhoozhoo requested a review from Copilot March 18, 2026 20:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors shared infrastructure across the microservices to centralize common WebFlux configuration and introduce URL-path API versioning (/api/v1/...) plus pagination support on list endpoints.

Changes:

  • Added shared Spring Boot auto-configurations (API versioning, global exception handling, R2DBC conversions, validation).
  • Updated REST endpoints and gateway routing to use /api/v1/** and added page/size pagination to list APIs.
  • Refactored controllers/services/models to reduce boilerplate (e.g., withOwner(...) / withIdAndOwner(...)) and removed per-service duplicate configs/handlers.

Reviewed changes

Copilot reviewed 203 out of 203 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/rifles-service.http Update REST Client examples to /api/v1.
test/load_test_data.sh Update API base path to /api/v1.
test/README.adoc Trim/adjust testing guide content.
shared/src/test/java/ca/zhoozhoo/loaddev/common/validation/PositiveQuantityValidatorTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/validation/NotNullQuantityValidatorTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/r2dbc/R2dbcConvertersTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/UnitSerializerTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/UnitDeserializerTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/QuantityModuleTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/QuantityModuleSupportTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/QuantityDeserializerTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/MonetaryAmountSerializerTest.java Comment/doc style adjustments.
shared/src/test/java/ca/zhoozhoo/loaddev/common/jackson/MonetaryAmountDeserializerTest.java Comment/doc style adjustments.
shared/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports Register new shared auto-configurations.
shared/src/main/java/ca/zhoozhoo/loaddev/common/web/GlobalExceptionHandler.java Move/expand shared global exception handling.
shared/src/main/java/ca/zhoozhoo/loaddev/common/validation/PositiveQuantityValidator.java Comment/doc style adjustments.
shared/src/main/java/ca/zhoozhoo/loaddev/common/validation/NotNullQuantityValidator.java Comment/doc style adjustments.
shared/src/main/java/ca/zhoozhoo/loaddev/common/opentelemetry/HeaderLoggerFilter.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/opentelemetry/FilterConfiguration.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/opentelemetry/AddTraceIdFilter.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/UnitSerializer.java Comment/doc refactor; minor comment style.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/UnitDeserializer.java Comment/doc refactor; minor comment style.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/QuantitySerializer.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/QuantityModuleSupport.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/QuantityModule.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/QuantityDeserializer.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/MonetaryAmountSerializer.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/jackson/MonetaryAmountDeserializer.java Comment/doc refactor; keep behavior.
shared/src/main/java/ca/zhoozhoo/loaddev/common/autoconfigure/ValidationAutoConfiguration.java Add shared validation auto-config.
shared/src/main/java/ca/zhoozhoo/loaddev/common/autoconfigure/R2dbcAutoConfiguration.java Add shared R2DBC conversions auto-config.
shared/src/main/java/ca/zhoozhoo/loaddev/common/autoconfigure/QuantityModuleAutoConfiguration.java Provide QuantityModule via auto-config.
shared/src/main/java/ca/zhoozhoo/loaddev/common/autoconfigure/GlobalExceptionHandlerAutoConfiguration.java Auto-configure shared exception handler.
shared/src/main/java/ca/zhoozhoo/loaddev/common/autoconfigure/ApiVersionAutoConfiguration.java Enable WebFlux API versioning/prefix.
shared/pom.xml Add optional deps + Lombok processor.
shared-security/src/test/java/ca/zhoozhoo/loaddev/security/SecurityAutoConfigurationTest.java Comment/doc style adjustments.
shared-security/src/test/java/ca/zhoozhoo/loaddev/security/KeycloakPermissionsConverterTest.java Comment/doc style adjustments.
shared-security/src/test/java/ca/zhoozhoo/loaddev/security/KeycloakPermissionsConverterEdgeCasesTest.java Comment/doc style adjustments.
shared-security/src/test/java/ca/zhoozhoo/loaddev/security/CurrentUserMethodArgumentResolverTest.java Comment/doc style adjustments.
shared-security/src/test/java/ca/zhoozhoo/loaddev/security/CurrentUserIntegrationTest.java Comment/doc style adjustments.
shared-security/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports Register WebFlux auto-config.
shared-security/src/main/java/ca/zhoozhoo/loaddev/security/WebFluxAutoConfiguration.java Auto-register argument resolver.
shared-security/src/main/java/ca/zhoozhoo/loaddev/security/SecurityAutoConfiguration.java Comment/doc refactor; keep behavior.
shared-security/src/main/java/ca/zhoozhoo/loaddev/security/KeycloakPermissionsConverter.java Comment/doc refactor; keep behavior.
shared-security/src/main/java/ca/zhoozhoo/loaddev/security/CurrentUserMethodArgumentResolver.java Comment/doc refactor; keep behavior.
shared-security/src/main/java/ca/zhoozhoo/loaddev/security/CurrentUser.java Comment/doc refactor; keep behavior.
shared-integration-testing/src/main/java/ca/zhoozhoo/loaddev/test/testcontainers/KeycloakTest.java Comment/doc style adjustments.
rifles-service/src/test/java/ca/zhoozhoo/loaddev/rifles/web/GlobalExceptionHandlerTest.java Remove redundant handler unit tests.
rifles-service/src/test/java/ca/zhoozhoo/loaddev/rifles/model/RifleTest.java Comment/doc style adjustments.
rifles-service/src/test/java/ca/zhoozhoo/loaddev/rifles/dao/RifleRepositoryTest.java Comment/doc style adjustments.
rifles-service/src/test/java/ca/zhoozhoo/loaddev/rifles/config/TestSecurityConfig.java Comment/doc style adjustments.
rifles-service/src/test/java/ca/zhoozhoo/loaddev/rifles/RiflesServiceApplicationTest.java Comment/doc style adjustments.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/web/GlobalExceptionHandler.java Remove service-local exception handler.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/service/RiflesService.java Add pagination to list method.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/model/Zeroing.java Comment/doc style adjustments.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/model/TwistDirection.java Comment/doc style adjustments.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/model/Rifling.java Comment/doc style adjustments.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/model/Rifle.java Add record copy helpers.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/dao/RifleRepository.java Add Pageable overload.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/config/WebConfig.java Remove service-local WebFlux config.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/config/R2dbcConfig.java Remove service-local R2DBC config.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/config/JacksonConfig.java Remove service-local Jackson config.
rifles-service/src/main/java/ca/zhoozhoo/loaddev/rifles/RiflesServiceApplication.java Comment/doc style adjustments.
pom.xml Fix surefire argLine preview flags.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/provider/ToolReactiveContextTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/provider/PreSerializationUtilsTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/dto/LoadDetailsTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/config/SpringObjectMapperMcpJsonMapperTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/config/SecurityConfigTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/config/McpServerConfigTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/config/JacksonConfigTest.java Comment/doc style adjustments.
mcp-server/src/test/java/ca/zhoozhoo/loaddev/mcp/McpServerApplicationTests.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/provider/ToolReactiveContext.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/provider/RiflesToolProvider.java Switch to constructor injection.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/provider/PreSerializationUtils.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/provider/LoadResourceProvider.java Switch to constructor injection.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/ZeroingDto.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/ShotDto.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/RiflingDto.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/RifleDto.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/LoadDto.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/LoadDetails.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/dto/GroupDto.java Comment/doc style adjustments.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/config/SpringObjectMapperMcpJsonMapper.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/config/SecurityConfig.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/config/McpServerConfig.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/config/McpJsonMappingException.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/config/JacksonConfig.java Comment/doc refactor; keep behavior.
mcp-server/src/main/java/ca/zhoozhoo/loaddev/mcp/McpServerApplication.java Comment/doc refactor; keep behavior.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/web/GlobalExceptionHandlerTest.java Remove redundant handler unit tests.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/service/VelocityStatisticsGathererTest.java Add gatherer tests; doc refactor.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/service/ShotServiceTest.java Update tests for pagination signature.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/service/LoadServiceTest.java Update tests for pagination signature.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/service/GroupServiceTest.java Update tests for pagination signature.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/model/ShotTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/model/LoadTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/model/GroupTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/model/GroupStatisticsTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/mapper/GroupStatisticsMapperTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/dao/ShotRepositoryTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/dao/LoadRepositoryTest.java Update tests for pagination.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/dao/GroupRepositoryTest.java Comment/doc style adjustments.
loads-service/src/test/java/ca/zhoozhoo/loaddev/loads/config/TestSecurityConfig.java Comment/doc style adjustments.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/web/ShotsController.java Add pagination params + record helpers.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/web/GroupsController.java Add pagination params + record helpers.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/service/VelocityStatisticsGatherer.java Add Stream Gatherer implementation.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/service/ShotService.java Add pagination to list service method.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/service/LoadService.java Add pagination to list service method.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/model/Shot.java Add record copy helpers.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/model/Load.java Add record copy helpers.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/model/GroupStatistics.java Comment/doc style adjustments.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/model/Group.java Add record copy helpers.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/mapper/GroupStatisticsMapper.java Comment/doc style adjustments.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/dto/ShotDto.java Comment/doc style adjustments.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/dto/GroupStatisticsDto.java Comment/doc style adjustments.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/dao/ShotRepository.java Add Pageable overload.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/dao/LoadRepository.java Switch to pageable list query.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/dao/GroupRepository.java Add Pageable overload.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/config/WebConfig.java Remove service-local WebFlux config.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/config/ValidationConfig.java Remove service-local validation config.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/config/R2dbcConfig.java Remove service-local R2DBC config.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/config/JacksonConfig.java Remove service-local Jackson config.
loads-service/src/main/java/ca/zhoozhoo/loaddev/loads/LoadsServiceApplication.java Comment/doc style adjustments.
helm/spring-load-development/charts/reloading/templates/configmaps.yaml Update gateway route predicates to /api/v1.
discovery-server/src/main/java/ca/zhoozhoo/loaddev/discovery/DiscoveryServiceApplication.java Comment/doc style adjustments.
config-server/src/main/java/ca/zhoozhoo/loaddevelopment/config/ConfigServerApplication.java Comment/doc style adjustments.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/service/PropellantServiceTest.java Update tests for pagination/search paging.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/service/ProjectileServiceTest.java Update tests for pagination/search paging.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/service/PrimerServiceTest.java Update tests for pagination/search paging.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/service/CaseServiceTest.java Update tests for pagination/search paging.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/model/PropellantTest.java Comment/doc style adjustments.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/model/ProjectileTest.java Comment/doc style adjustments.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/model/PrimerTest.java Comment/doc style adjustments.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/model/PrimerSizeTest.java Comment/doc style adjustments.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/model/CaseTest.java Comment/doc style adjustments.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/dao/PropellantRepositoryTest.java Update tests for pageable queries/search.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/dao/ProjectileRepositoryTest.java Update tests for pageable queries/search.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/dao/PrimerRepositoryTest.java Update tests for pageable queries/search.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/dao/CaseRepositoryTest.java Update tests for pageable queries/search.
components-service/src/test/java/ca/zhoozhoo/loaddev/components/config/TestSecurityConfig.java Comment/doc style adjustments.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/model/Propellant.java Add record copy helpers.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/model/Projectile.java Add record copy helpers.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/model/PrimerSize.java Comment/doc style adjustments.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/model/Primer.java Add record copy helpers.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/model/Case.java Add record copy helpers.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/dao/PropellantRepository.java Add Pageable + LIMIT/OFFSET search.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/dao/ProjectileRepository.java Add Pageable + LIMIT/OFFSET search.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/dao/PrimerRepository.java Add Pageable + LIMIT/OFFSET search.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/dao/CaseRepository.java Add Pageable + LIMIT/OFFSET search.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/config/WebConfig.java Remove service-local WebFlux config.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/config/R2dbcConfig.java Remove service-local R2DBC config.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/config/JacksonConfig.java Remove service-local Jackson config.
components-service/src/main/java/ca/zhoozhoo/loaddev/components/ComponentsServiceApplication.java Comment/doc style adjustments.
api-gateway/src/test/java/ca/zhoozhoo/loaddev/api/security/UmaTokenExchangeServiceTest.java Comment/doc style adjustments.
api-gateway/src/test/java/ca/zhoozhoo/loaddev/api/config/TokenForwardingGatewayFilterFactoryTest.java Comment/doc style adjustments.
api-gateway/src/test/java/ca/zhoozhoo/loaddev/api/config/SecurityConfigurationIntegrationTest.java Comment/doc style adjustments.
api-gateway/src/test/java/ca/zhoozhoo/loaddev/api/config/PermissionTokenExchangeFilterTest.java Comment/doc style adjustments.
api-gateway/src/test/java/ca/zhoozhoo/loaddev/api/config/CacheConfigurationTest.java Comment/doc style adjustments.
api-gateway/src/test/java/ca/zhoozhoo/loaddev/api/ApiGatewayApplicationTests.java Comment/doc style adjustments.
api-gateway/src/main/java/ca/zhoozhoo/loaddev/api/security/UmaPermissionToken.java Comment/doc style adjustments.
api-gateway/src/main/java/ca/zhoozhoo/loaddev/api/security/TokenExchangeException.java Comment/doc style adjustments.
api-gateway/src/main/java/ca/zhoozhoo/loaddev/api/config/TokenForwardingGatewayFilterFactory.java Comment/doc refactor; keep behavior.
api-gateway/src/main/java/ca/zhoozhoo/loaddev/api/config/ObservationConfiguration.java Comment/doc refactor; keep behavior.
api-gateway/src/main/java/ca/zhoozhoo/loaddev/api/config/CacheConfiguration.java Comment/doc refactor; keep behavior.
api-gateway/src/main/java/ca/zhoozhoo/loaddev/api/ApiGatewayApplication.java Comment/doc refactor; keep behavior.
README.adoc Document API versioning + pagination; update examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zhoozhoo zhoozhoo merged commit 9fdf828 into main Mar 18, 2026
15 checks passed
@zhoozhoo zhoozhoo deleted the feature/refactorigs branch March 18, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants