Open
Conversation
Clean code / Use checkstyle
RegExp Comparison
DFA are good at matching missing, optional patterns. See https://swtch.com/~rsc/regexp/regexp1.html
zhztheplayer
reviewed
Aug 4, 2019
src/test/java/RegexTest.java
Outdated
| for (int i = 0; i < count; i++) { | ||
| result.append(str); | ||
| } | ||
| return result.toString; |
Owner
There was a problem hiding this comment.
Should it be return result.toString()?
Author
There was a problem hiding this comment.
@zhztheplayer You're correct. I tested only the Java 11 version and wrote a fix for versions < 11 by hand without testing. That fix included a typo which you correctly noted. I fixed that typo.
zhztheplayer
force-pushed
the
master
branch
2 times, most recently
from
d0f9392 to
a1b8992
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usual implementations don't match failing branches very well while DFAs do that very well. Let's show that! See https://swtch.com/~rsc/regexp/regexp1.html