Fixes issue with g_ContextMap outliving zgui#88
Merged
hazeycode merged 1 commit intozig-gamedev:mainfrom Mar 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a shutdown-time allocation lifetime problem in the vendored Dear ImGui GLFW backend where the static g_ContextMap can retain heap memory until process exit, causing leak reports (and, in shared-library scenarios, potential invalid MemFree calls after zgui is deinitialized).
Changes:
- Free
g_ContextMap’s backing storage duringImGui_ImplGlfw_Shutdown()when the map becomes empty, preventing late (atexit) frees. - Add an explanatory comment describing why the eager free is necessary in this integration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this is the way to go but this fixes #79 (and potentially #80).