Include emscripten sysroot with no backend option.#91
Open
asoderman wants to merge 1 commit intozig-gamedev:mainfrom
Open
Include emscripten sysroot with no backend option.#91asoderman wants to merge 1 commit intozig-gamedev:mainfrom
asoderman wants to merge 1 commit intozig-gamedev:mainfrom
Conversation
hazeycode
requested changes
Jan 20, 2026
Member
There was a problem hiding this comment.
This will crash if the user does not have sysroot set. A user can provide emscripten paths using other means.
Perhaps we can add the include path simply if sysroot is not null (regardless of target and backend). If that's not tenable for some reason, then we should simply leave it to the user to add include paths to the imgui build artefact themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an issue for users compiling with emscripten when no backend is selected. In the dependent build.zig a user can set
zgui.builder.sysroot = <emscripten_sysroot>which will then compile imgui with the necessary headers. Without this change the imgui compilation step is unable to locate <assert.h>.Context:
I am trying to add zgui to my existing project which uses raylib. In order to do this I need to use the rlImgui backend and compile zgui with no backend. This worked out of the box for native builds but broke my wasm build.