Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates the compile-time helper functions for defining Forth words, reducing code duplication by eliminating defword_, defcode_, defcode, and defconst in favor of a single defword function with specialized helper functions (wrap, attr, value, words) that generate instruction sequences.
Key changes:
- Unified word definition through a single
defwordfunction with helper functions for common patterns - Replaced
defcodewithwrap()for stack manipulation operations - Replaced
defconstwithvalue()for literal constants andattr()for interpreter field addresses - Added
words()helper to build composite words from other word references
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Afirium
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate
defword_,defcode_,defcode,defconst, anddefwordinto justdefwordwith shorter helpers to generate repetitive code such as constants and stack manipulations.