Add room_temperature attribute for Sinope floor heat thermostat#325
Draft
decompil3d wants to merge 2 commits intozigpy:devfrom
Draft
Add room_temperature attribute for Sinope floor heat thermostat#325decompil3d wants to merge 2 commits intozigpy:devfrom
decompil3d wants to merge 2 commits intozigpy:devfrom
Conversation
Contributor
|
This won't create a new entity. It'll only initialize (read) the The original In the end, it should look something like this I think: (
QuirkBuilder(SINOPE, "TH1300ZB")
.replaces(SinopeTechnologiesElectricalMeasurementCluster)
.replaces(SinopeTechnologiesThermostatCluster)
.replaces(SinopeTechnologiesManufacturerCluster)
.sensor(
attribute_name=SinopeTechnologiesManufacturerCluster.AttributeDefs.floor_temperature.name,
cluster_id=SinopeTechnologiesManufacturerCluster.cluster_id,
device_class=SensorDeviceClass.TEMPERATURE,
state_class=SensorStateClass.MEASUREMENT,
unit=UnitOfTemperature.CELSIUS,
translation_key="room_temperature",
fallback_name="Room temperature",
)
.add_to_registry()
)Drafting this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks - this is my first time contributing here. I've got this Sinope floor heat thermostat. The quirk for it already knows about the
room_temperatureattribute. But I want to expose that attribute as a Home Assistant sensor.I think this is how to do it, but I'd appreciate any feedback. Also, I'm not sure how to test this - is there an easy way to try this on my HA instance to verify that it works?
Thanks for your help!