Update default precision for instantaneous demand + current#624
Draft
TheJulianJES wants to merge 3 commits intozigpy:devfrom
Draft
Update default precision for instantaneous demand + current#624TheJulianJES wants to merge 3 commits intozigpy:devfrom
TheJulianJES wants to merge 3 commits intozigpy:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #624 +/- ##
=======================================
Coverage 97.01% 97.02%
=======================================
Files 63 63
Lines 10569 10571 +2
=======================================
+ Hits 10254 10256 +2
Misses 315 315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the suggested display precision for the instantaneous demand entity and the RMS current entity.
The instantaneous demand entity then aligns with the EM active power entities (suggested precision 1).
The RMS current entity uses suggested precision 2 to not cut off low-power draw devices, often attached to smart plugs.