Skip to content

switch to serious multi-byte testing#13

Open
zikaari wants to merge 1 commit intomasterfrom
better-benchmarks
Open

switch to serious multi-byte testing#13
zikaari wants to merge 1 commit intomasterfrom
better-benchmarks

Conversation

@zikaari
Copy link
Copy Markdown
Owner

@zikaari zikaari commented Jun 27, 2018

No description provided.

@zikaari zikaari requested a review from aeschli June 27, 2018 06:34
@zikaari
Copy link
Copy Markdown
Owner Author

zikaari commented Nov 12, 2019

@aeschli any thoughts on including this in the next release?

@aeschli
Copy link
Copy Markdown
Collaborator

aeschli commented Nov 12, 2019

+1 for improving our benchmark. But I would suggest to add a new test instead of replacing the existing one.
Also I would suggest avoiding randomized inputs but use real-world examples.

  • avoid random to make it reproducible
  • avoid optimizing against inputs that are rare or net even existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants