Support for weaviate vector store by sunilkumardash9 · Pull Request #474 · zilliztech/GPTCache

sunilkumardash9 · 2023-07-07T11:22:22Z

Added support for the Weaviate vector store #340

sre-ci-robot · 2023-07-07T11:22:31Z

Welcome @sunilkumardash9! It looks like this is your first PR to zilliztech/GPTCache 🎉

SimFG · 2023-07-07T11:25:27Z

@sunilkumardash9 thank your contribution. please use the dev as the target branch

sre-ci-robot · 2023-07-07T11:45:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunilkumardash9
To complete the pull request process, please assign cxie after the PR has been reviewed.
You can assign the PR to them by writing /assign @cxie in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Add Qdrant vector store client * Add setup for Qdrant vector store * Add lazy import for Qdrant client library * Add import_qdrant to index file * Use models not types for building configs * Add tests for Qdrant vector store Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

* [add] support for mongodb store * [add] unit test for mongodb store * [mod] using [] instead of list, oid instead of _id, change unit tests Signed-off-by: Anurag <a9raag@gmail.com> * [add] Docker image for mongo, optimized imports Signed-off-by: Anurag <a9raag@gmail.com> * [refactor] disable warnings for `wrong-import-position` Signed-off-by: Anurag <a9raag@gmail.com> --------- Signed-off-by: Anurag <a9raag@gmail.com> Co-authored-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

) Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

1. Placed import_weaviate() before importing its functions 2. changed parameter name from 'collection_name' to 'class_name' 3. Few cosmetic changes

1. Removed a hard-coded class_name in delete method 2. Better type check

sunilkumardash9 · 2023-07-20T16:58:09Z

@SimFG I think we need to update the SQLite versions. Python 3.8 probably ships with an older version that isn't supported anymore in chroma.

SimFG · 2023-07-21T02:03:23Z

@sunilkumardash9 it will be fixed in #488 pr

SimFG · 2023-07-21T08:37:09Z

@sunilkumardash9 I have handled the error, pr: #492

use old chromadb

codecov · 2023-07-22T01:14:37Z

Codecov Report

Merging #474 (3dc0c73) into dev (bd152a7) will decrease coverage by 0.14%.
The diff coverage is 85.29%.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #474      +/-   ##
==========================================
- Coverage   94.07%   93.94%   -0.14%     
==========================================
  Files          93       94       +1     
  Lines        3817     3883      +66     
==========================================
+ Hits         3591     3648      +57     
- Misses        226      235       +9

Impacted Files	Coverage Δ
gptcache/manager/scalar_data/mongo.py	`92.95% <0.00%> (ø)`
gptcache/manager/vector_data/weaviate.py	`82.00% <82.00%> (ø)`
gptcache/manager/vector_data/manager.py	`99.19% <100.00%> (+0.10%)`	⬆️
gptcache/utils/__init__.py	`89.34% <100.00%> (+0.17%)`	⬆️

SimFG · 2023-07-22T09:28:37Z

@sunilkumardash9 i will merge the pr: #493, because the pr fully meet the entry requirements.
Do you have some ideas? If have, please tell me as soon as possible, it is expected that I will merge today.

sunilkumardash9 · 2023-07-22T09:34:14Z

@SimFG No sir, you are free to merge.

SimFG · 2023-07-22T11:39:14Z

@sunilkumardash9 thank for your contribution and attention

SimFG · 2023-07-25T06:07:19Z

@sunilkumardash9 i will close the pull request. And if you have more ideas, please feel free to open a new pull request

sre-ci-robot requested review from cxie and xiaofan-luan July 7, 2023 11:22

sre-ci-robot added the size/L label Jul 7, 2023

mergify bot added the needs-dco label Jul 7, 2023

SimFG changed the base branch from main to dev July 7, 2023 11:28

parthvnp and others added 7 commits July 7, 2023 17:23

Fix the pylint error and add the chromedb test (zilliztech#457)

3bde5c4

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

Fix the wrong return value of onnx similarity evaluation (zilliztech#460

5211378

) Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

Update the version to 0.1.34

d4154d4

Signed-off-by: SimFG <bang.fu@zilliz.com> Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

added support for weaviate vector-store

90d4991

Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

removed relative imports of weaviate class

b6a1899

Signed-off-by: sunilkumardash9 <sunilkumardash9@gmail.com>

sunilkumardash9 force-pushed the support-for-Weaviate branch from 8460083 to b6a1899 Compare July 7, 2023 12:18

sre-ci-robot added size/XXL and removed size/L labels Jul 7, 2023

mergify bot added dco-passed and removed needs-dco labels Jul 7, 2023

Merge branch 'dev' into support-for-Weaviate

70d0fd0

sre-ci-robot added size/L and removed size/XXL labels Jul 18, 2023

Update weaviate.py few corrections

d270e08

1. Placed import_weaviate() before importing its functions 2. changed parameter name from 'collection_name' to 'class_name' 3. Few cosmetic changes

mergify bot added needs-dco and removed dco-passed labels Jul 18, 2023

Update weaviate.py

abc764d

1. Removed a hard-coded class_name in delete method 2. Better type check

Update __init__.py

3dc0c73

use old chromadb

SimFG closed this Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for weaviate vector store #474

Support for weaviate vector store #474
sunilkumardash9 wants to merge 11 commits intozilliztech:devfrom
sunilkumardash9:support-for-Weaviate

sunilkumardash9 commented Jul 7, 2023

Uh oh!

sre-ci-robot commented Jul 7, 2023

Uh oh!

SimFG commented Jul 7, 2023

Uh oh!

sre-ci-robot commented Jul 7, 2023

Uh oh!

sunilkumardash9 commented Jul 20, 2023

Uh oh!

SimFG commented Jul 21, 2023

Uh oh!

SimFG commented Jul 21, 2023

Uh oh!

codecov bot commented Jul 22, 2023 •

edited

Loading

Uh oh!

SimFG commented Jul 22, 2023

Uh oh!

sunilkumardash9 commented Jul 22, 2023

Uh oh!

SimFG commented Jul 22, 2023

Uh oh!

SimFG commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sunilkumardash9 commented Jul 7, 2023

Uh oh!

sre-ci-robot commented Jul 7, 2023

Uh oh!

SimFG commented Jul 7, 2023

Uh oh!

sre-ci-robot commented Jul 7, 2023

Uh oh!

sunilkumardash9 commented Jul 20, 2023

Uh oh!

SimFG commented Jul 21, 2023

Uh oh!

SimFG commented Jul 21, 2023

Uh oh!

codecov bot commented Jul 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SimFG commented Jul 22, 2023

Uh oh!

sunilkumardash9 commented Jul 22, 2023

Uh oh!

SimFG commented Jul 22, 2023

Uh oh!

SimFG commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jul 22, 2023 •

edited

Loading