fix: updates to questtrack and network functions and emoteSpells config#594
Merged
jprzimba merged 3 commits intozimbadev:mainfrom Feb 10, 2026
Merged
fix: updates to questtrack and network functions and emoteSpells config#594jprzimba merged 3 commits intozimbadev:mainfrom
jprzimba merged 3 commits intozimbadev:mainfrom
Conversation
Mateuzkl
changed the title
jprzimba
changed the title
Collaborator
|
Thank you |
FelipeArruda
pushed a commit
to FelipeArruda/crystalserver
that referenced
this pull request
Mar 8, 2026
…ig (zimbadev#594) * Fix: updates to questtrack and network functions * fix(spells): use TALKTYPE_SAY for yellow spell text when emoteSpells is disabled * Fix: corrected emoSpells in player.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. Protocol desynchronization on diagonal movement
Fixed black border bug during diagonal movement. The protocol wasn't sending correct map description on login, causing client desync when using numpad diagonal keys.
Commit: ecdb60b
2. emoteSpells config now correctly shows yellow text when disabled
Previously, when
emoteSpellswas set tofalsein config.lua, spell text still appeared in orange color. This was caused usingTALKTYPE_SPELL_USEwhich OTClient treats the same asTALKTYPE_MONSTER_SAY(both render as orange).Solution: Changed to use
TALKTYPE_SAYwhen emoteSpells is false, which correctly renders as yellow text in OTClient.Behavior:
emoteSpells = true: Orange emote above character (TALKTYPE_MONSTER_SAY)emoteSpells = false: Yellow text in chat (TALKTYPE_SAY)Testing