Skip to content

refactor: fix subcommand type mapping and update git example #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yutubeboss575-create wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: fix subcommand type mapping and update git example #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions examples/jvm/src/main/scala/zio/cli/examples/GitExample.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,18 @@ object GitExample extends ZIOCliDefault {
Subcommand.Remote.Add(name, url)
}
}

val remoteRemove = {
val remoteRemoveHelp: HelpDoc = HelpDoc.p("Remove remote subcommand description")
Command("remove", Args.text("name")).withHelp(remoteRemoveHelp).map(Subcommand.Remote.Remove)
}

val remoteHelp: HelpDoc = HelpDoc.p("Remote subcommand description")
val remote =
// val gitRemote = Command("remote", verboseFlag).withHelp(remoteHelp).map(Subcommand.Remote(_))
// val gitRemoteAdd = Command("remote").withHelp(remoteHelp).subcommands(remoteAdd)
// val gitRemoteRemove = Command("remote").withHelp(remoteHelp).subcommands(remoteRemove)
// gitRemote | gitRemoteAdd | gitRemoteRemove

val remote =
Command("remote", verboseFlag)
.withHelp(remoteHelp)
.map(Subcommand.Remote(_))
.subcommands(remoteAdd, remoteRemove)
.map(_._2) // TODO: We shouldn't have to discard the standalone remote command

val git: Command[Subcommand] =
Command("git", Options.none, Args.none).subcommands(add, remote)

Expand Down
Loading