Refactor/analysis merge annotation#2031
Merged
DerManoMann merged 2 commits intoJun 29, 2026
Merged
Conversation
…eness Processors that create annotations via merge() previously needed to separately call addAnnotation() to register them. This was error-prone and left the registries incomplete. mergeAnnotations() combines both operations, closing the gap between the annotation tree and the flat registry index. Migrated processors: MergeIntoOpenApi, MergeIntoComponents, AugmentSchemas, AugmentParameters, AugmentTags, BuildPaths. Also fixes incorrect 'nested' context value in AugmentParameters ($this -> null). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…actory The 'nested' context flag uses null to mean "no parent" and an AbstractAnnotation instance to mean "has parent". The value false was inconsistent with this convention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DerManoMann
force-pushed
the
refactor/analysis-merge-annotation
branch
from
c045ece to
471cd91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge()) with registry registration (addAnnotation())$this/false)Test plan