Conversation
Pipeline routes were mounted without requireBearerToken, exposing all CRUD/execution endpoints to unauthenticated callers. getTenantId() trusted the x-tenant-id header, allowing any caller to impersonate any tenant. - Add requireBearerToken middleware to pipeline route mount (index.ts) - Replace header-based tenant resolution with auth-derived identity (mcpUser.id from Bearer token, matching tools/executor.ts pattern) - Update route tests to use mcpUser instead of x-tenant-id header Ref: PR #28 review findings 1a/1b (grndlvl), issue #37 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two security issues from grndlvl's review on PR #28 (Finding 1a/1b):
/api/pipelines/*were accessible without authentication. AddedrequireBearerTokenmiddleware to the route mount inindex.ts.getTenantId()trusted thex-tenant-idrequest header, allowing any caller to impersonate any tenant. Replaced with auth-derived identity (req.mcpUser.idfrom Bearer token), matching the existing pattern intools/executor.ts.Files changed (3)
src/index.tsrequireBearerTokento pipeline route mountsrc/pipelines/routes.tsgetTenantId()— remove header trust, usemcpUser.idtests/pipelines/routes.test.tsmcpUserinstead ofx-tenant-idheaderContext
fix/009-pipeline-review-findingsTest plan
vitest run tests/pipelines/routes.test.ts— 13/13 passtsc --noEmit— 0 new errors (pre-existing inngest type errors only)inngestpackagex-tenant-idheader no longer appears in pipeline route logic🤖 Generated with Claude Code