Translate Notifications#438
Conversation
zjs81
left a comment
There was a problem hiding this comment.
Look good except requires some minor changes
|
Sorry didn't know that they need specific prompt. I tried and tested it, and it worked. It could be that it took a little longer to translate and that would explain it, but otherwise I got less german to german translations. I also did the simple translation heuristics PR. But it is really simple and gives sometimes the wrong language. I tried other methods like n-gramms with weigthened scores, but the results were not better, which is why I published the simplest method. I think the best solution would be to use the model to recognize and return the language, but I can not find a prompt for that. Or someone has an other Idea that is working better, as the keyword approach. Sincerely Eric |
|
You should use this https://pub.dev/documentation/flutter_langdetect/latest/ |
|
It is also a n-gramm approach, but with a lot more statistics behind it, than i could provide. |
|
I would say go ahead and do it in this PR. If we are going to use this lib we should just put it in our helper that way it can also be used else where. Thank you! |
1d0b141 to
75ae903
Compare
|
Sorry pushed a test, I didn't want to. |
|
How well does it work so far? |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75ae903b99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
The Language detection Library works a lot better, than the previous implementation. But through the small Texts like "Hallo", which could be FI as also DE, you still get false Positives. I don't think we can get rid of that completely. |
A change to translate Notification, if translation is enabled.
Implementation of Issue #366
Best Regards Eric