Fix YOLO model postprocessing and bounding box overlay#1
Conversation
Co-authored-by: zlen2024 <162661683+zlen2024@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit fixes the issue where the user sees hundreds of bounding boxes misaligned with the camera feed. 1) Removed the faulty needsSigmoid check, treating all output as probability since the YOLO ONNX model already applies Sigmoid. 2) Fixed the camera byte buffer to pixel mapping for devices with non-matching rowStride and pixelStride. 3) Scaled bounding boxes correctly based on PreviewView's FILL_CENTER behavior.
PR created automatically by Jules for task 10350251975255981139 started by @zlen2024