Refactor dashboard to dedicated pages for connections, settings, and API keys#5
Open
zonlabs wants to merge 2 commits intochore/bump-ts-packagesfrom
Open
Refactor dashboard to dedicated pages for connections, settings, and API keys#5zonlabs wants to merge 2 commits intochore/bump-ts-packagesfrom
zonlabs wants to merge 2 commits intochore/bump-ts-packagesfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
app/dashboard/app/dashboard/connections/page.tsxso the connections UI lives on/dashboard/connectionsand retains the original client behavior and components.app/dashboard/app/dashboard/page.tsxto redirect to/dashboard/connectionsto make/dashboardan entrypoint that routes to the connections page.app/dashboard/app/dashboard/api-keys/page.tsxwhich rendersLLMKeySettingswith a page header to expose/dashboard/api-keysfor gateway API key management.app/dashboard/app/dashboard/settings/[...id]/page.tsxto read the first path segment and renderConnectionSettings, and updated the connections view to userouter.push('/dashboard/settings/{id}')androuter.push('/dashboard/api-keys')for navigation instead of in-page tab-only state.Testing
pnpm -s exec eslint app/dashboard/page.tsx app/dashboard/api-keys/page.tsx app/dashboard/settings/[...id]/page.tsxwhich passed for those files.pnpm -s exec eslint app/dashboard/connections/page.tsxsurfaced pre-existing lint errors (legacyanytypes and other client-page issues) which are unrelated to the routing refactor and remain to be addressed separately.pnpm -s lintwhich failed due to existing repository lint rules across multiple files (not introduced by this refactor).pnpm dev --port 3005and exercised the/dashboardroute via an automated Playwright script which produced a screenshot showing the redirected routing flow, though local Supabase env vars were not present in this environment (middleware reported missing SUPABASE values).Codex Task