Skip to content

Add incompatible log for dependency pick list#57

Open
edclements wants to merge 3 commits intozont:masterfrom
BookingBug:master
Open

Add incompatible log for dependency pick list#57
edclements wants to merge 3 commits intozont:masterfrom
BookingBug:master

Conversation

@edclements
Copy link
Copy Markdown

With interactive set to true the user is presented with a prompt to specify a dependency when incompatibilities are found. This change logs the possible choices before the prompt.

@codecov-io
Copy link
Copy Markdown

Current coverage is 73.68% (diff: 11.11%)

Merging #57 into master will decrease coverage by 23.25%

@@             master        #57   diff @@
==========================================
  Files             1          1          
  Lines            98        133    +35   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             95         98     +3   
- Misses            3         35    +32   
  Partials          0          0          

Powered by Codecov. Last update 02704fd...fedf1d7

Comment thread index.js

if (logdata.suitable) {

str += gutil.colors.yellow('\nPlease not that,\n');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistake: 'not' -> 'note'

@Crevil
Copy link
Copy Markdown

Crevil commented Aug 26, 2016

I think this is good!
Could you add some tests as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants