fix: initialization order for error reporting and ensure zero-initialized buffers

[sachintu47]

fix: initialization order for error reporting and ensure zero-initialized buffers

[augmentcode]

🤖 Augment PR Summary

Summary: Moves DBG_Opts initialization earlier in open_dataset() so error reporting is available before subsequent dataset setup steps.
Also: Ensures dataset read buffers are zero-initialized/cleared between reads and treats BPAM member read failures as hard errors (logging the actual bytes_read).

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

init_opts() snapshots dfile->debug into opts->debug, but LIBDIO_DEBUG is applied later, so opts->debug can stay disabled even when debugging is enabled. That can make any DBG_Opts-controlled debug output inconsistent with dfile->debug.

Severity: low

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[sachintu47]

augment review

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

dfile->opts is allocated with calloc() but not checked before calling init_opts(), so an OOM here could lead to a NULL dereference inside init_opts. Consider handling dfile->opts == NULL similarly to the other allocation-failure paths in open_dataset().

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}