Enabling provider support - now - default and oqs-provider in openssl#62
Draft
HarithaIBM wants to merge 9 commits into
Draft
Enabling provider support - now - default and oqs-provider in openssl#62HarithaIBM wants to merge 9 commits into
HarithaIBM wants to merge 9 commits into
Conversation
| + shared_cflag => "-fPIC", | ||
| + shared_ldflag => "-shared -fvisibility=default -Wl,-bedit=no", | ||
| + shared_extension => ".so", | ||
| + dso_ldflag => "-shared -fvisibility=default -Wl,-bedit=no", |
Member
There was a problem hiding this comment.
We should remove edit=no here
| + int rc = dlclose(lib); | ||
| + if (rc != 0) { | ||
| + const char *err = dlerror(); | ||
| + if (err && strstr(err, "CEE3567I")) |
Member
There was a problem hiding this comment.
Can you explain the CEE3567I check?
Member
Author
There was a problem hiding this comment.
This is an acceptable return value on dlclose
The DLL Free or C dlclose() request completed successfully. DLL dll-name is not physically deleted because either there was an implicit DLL Load performed against this DLL by the application, or multiple DLL Load or C dlopen() requests were made for the DLL
More info is here
So, filtered 2 acceptable return values ad added more comments in test code
and retry limit
Member
Author
|
/run tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.