Added PKCS12 support to App-server#596
Draft
1000TurquoisePogs wants to merge 12 commits intov3.x/stagingfrom
Draft
Added PKCS12 support to App-server#5961000TurquoisePogs wants to merge 12 commits intov3.x/stagingfrom
1000TurquoisePogs wants to merge 12 commits intov3.x/stagingfrom
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
This was referenced Mar 20, 2025
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
timgerstel
approved these changes
Apr 7, 2025
github-project-automation
bot
moved this from Ready for Review
to Merge Ready
in WebUI planning board
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, app-server can now load PKCS12 content when provided in
zowe.certificate.keystoreandzowe.certificate.truststore, orcomponents.app-server.nodeConfig.https[key/cert/certificateAuthorities]In other words, you no longer need to use either SAF keyring or PEM, now PKCS12 is also possible to use.
To load a PKCS12 object, the server looks for the zowe config parameters
zowe.certificate.keystore.passwordandzowe.certificate.keystore.aliasto find key/cert, while usingzowe.certificate.truststore.passwordto find CAs.These values importantly not part of the app-server's config, but part of the zowe global config.
I have added debug messages for the _zsf.bootstrap logger.
I have removed support of reading of
components.app-server.nodeConfig.https.pfxbecause it was never used - PFX is quite similar to PKCS12 so, just use this new PKCS12 loading in the standard zowe way.How to test:
Load up zowe with PKCS12 instead of SAF keyring, and put dummy values into the pem section - they wont be loaded. You should still be able to log into the Desktop!
You can't remove the PEM section of the Zowe YAML yet because the schema expects it, but that can be handled in a different PR.