Move benchmark-only deps behind build tag#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
leveldb,wal, andlz4are only used by benchmarks andgookit/coloroverlaps withptermutilities.go test/ build faster and avoid pulling heavy benchmark-only modules during normal development.Description
cmd_vfs_raw_bench_test.goguarded by//go:build benchmarkso benchmark-only imports are only required for benchmark builds.cmd_vfs_raw_test.goto keep only unit tests and removed benchmark helpers from that file.github.com/gookit/colorinpterm_writer.gowithpterm.RemoveColorFromStringto rely onptermutilities instead of an extra color dependency.github.com/pierrec/lz4/v4,github.com/syndtr/goleveldb,github.com/tidwall/wal, andgithub.com/gookit/color) from the mainrequireblock and cleaned corresponding entries fromgo.sum.Testing
gofmton modified files successfully to normalize formatting and committed the changes.go mod tidy, which could not complete fetching some modules due to proxy/network restrictions (module fetch errors for benchmark-only modules), so dependency verification for those modules was not completed.Codex Task