Open
Conversation
added 2 commits
November 29, 2023 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Lodash notoriously has many vulnerabilities. Even if these vulnerable parts of lodash aren't used, this will trigger vulnerability tooling such as SonaType. This pull request splits lodash into the four methods that are actually used and prevents having the entirety of lodash as a dependency.
Explain the details for making this change. What existing problem does the pull request solve?
This will prevent
assets-webpack-pluginfrom being flagged as a package with critical vulnerabilities.Test plan (required)
Use the plugin as-is, note it still works.
Closing issues
closes #459