refactor(context): decouple provider execution from context collector#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract context provider execution logic from
ContextCollectorinto a dedicatedContextProviderExecutor.This change is part of the Context Pipeline refactoring effort. The goal is to separate context collection responsibilities from provider lifecycle management, making the context system easier to extend and maintain.
Motivation
Previously,
ContextCollectorwas responsible for both:Memory,Workspace,User Context)ContextProvidersThis caused several issues:
ContextCollector.Changes
Added
ContextProviderExecutorIntroduced a dedicated executor responsible for provider execution lifecycle.
Responsibilities:
Updated
ContextCollectorContextCollectornow focuses only on:ContextSection.ContextDocument.Provider execution details are delegated to
ContextProviderExecutor.Design
Before:
After:
Behavior Changes
No changes to the external Context API.
ContextManagerand existing Agent execution flow continue to use the same context building interface.The main behavioral improvements are:
Follow-up
Future improvements planned:
AbortSignalsupport for provider cancellation.once,each_iteration,on_demand).