Refactored AdafruitMotorHat and AdafruitPwm constructors to allow stacking of other hats#45
Merged
Merged
Conversation
…or methods to allow then to receive the i2c device name and i2c slave device address The change allows me to stack other hats and address them correctly via i2c
Owner
hsalameh
approved these changes
Jul 13, 2017
Collaborator
hsalameh
left a comment
hsalameh
left a comment
There was a problem hiding this comment.
Why is the diff showing so many changes in some code that has not really changed?
|
@hsalameh it's white space changes – if you append "?w=1" to the files URL, e.g. https://github.com/zugaldia/android-robocar/pull/45/files?w=1 you'll see that the number of lines decreases by 300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored constructor methods of AdafruitPwm and AdafruitMotorHat classes so they can receive the i2c device name and i2c slave device address instead of having them hardcoded.
With the changes I'm commiting and a new driver I've written (inspired by Antonio's Motor Hat driver), I was able to stack the Adafruit 16-Channel PWM Servo Hat that I'm using to control the pan/tilt bracket's servos my camera module is mounted on, on top of the Adafruit DC and Stepper Motor HAT.