ci: build the site on every PR - #55
Merged
Merged
Conversation
The only workflow ran on push to main, so a broken artifact — including the docs sync the Zuke release pushes — was caught after it had already deployed. Run the same ./zuke build (npm ci, astro check, astro build) on every pull request, so the failure surfaces before the merge. This job is meant to become the required status check on main, which is what lets the release's website sync merge itself against a real gate instead of a manual click. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pull_requestworkflow running./zuke build— the same commanddeploy.ymlruns, sonpm ci,astro checkandastro buildall have to pass before anything lands onmain.Today the only workflow triggers on
push: [main], so a malformedpublic/llms.txtorsrc/data/api.jsonfrom the automated Zuke docs sync is discovered after it is already deployed. This moves that discovery to the PR.The job is named Build the site — that name is what gets required on
mainin the next step, and renaming it later would silently un-gate the branch, so the workflow says so in a comment.Note this PR validates itself: for a same-repo PR, GitHub runs the workflow file from the PR branch, so the check below is the gate proving it works before it becomes required.