Improve perf and fix permission denied errors with latest Chrome releases#96
Improve perf and fix permission denied errors with latest Chrome releases#96quark-zju wants to merge 2 commits intozumoshi:masterfrom
Conversation
Previously, this function scans all subdirectory files recursively. It's hitting "permissoin denied" errors for random files, on my machine. Change it to only look at the top-level directories. This should also improve performance significantly.
|
Looks good 👍🏼 Unfortunately, I don't have access to VS atm to be able to make a release. part of why the project is semi-abandoned is because I don't use it personally anymore since I switched to linux. Interested in becoming a maintainer and reviewing/merging other PRs and looking through issues? or is that kind of time commitment not feasible for you? I also made the offer to lucasnz who had made some improvements to the project before but got no response. |
Hi, I think I can do some lightweight maintenance to keep this project working while I use it. That said, I'm not super familiar with .net/C# so I probably will skip looking through most issues. I can take a look at the current PRs, though. |
|
Good to hear. sent an invite. I don't have github actions set up for it so unless you're up for setting that up you need to run nsis manually after you compiled it and upload after testing it. I'll do my best to answer any questions you had about the codebase as long as I remember, it has been a while since I last worked on this ... |
The latest Chrome release includes some features that disallows programs to read certain files, like:
Fix it by only visiting top-level directories to detect profiles. This should also improve performance.