Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 14
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "path": "src/core/radio-group/radio-group.tsx", | ||
| "content": "\"use client\";\n\nimport type { ReactNode } from \"react\";\n\nimport type {\n RadioGroupProps as AriaRadioGroupProps,\n RadioProps,\n ValidationResult,\n} from \"react-aria-components\";\nimport {\n Radio as AriaRadio,\n RadioGroup as AriaRadioGroup,\n FieldError,\n Text,\n} from \"react-aria-components\";\nimport { tv } from \"tailwind-variants\";\n\nconst radioGroup = tv({\n slots: {\n radio:\n \"flex items-center gap-4 text-fg before:block before:h-5 before:w-5 before:rounded-full before:border before:border-border before:ring-focus before:ring-offset-2 before:ring-offset-surface before:transition-all data-[selected]:before:border-4 data-[selected]:before:border-primary data-[focus-visible]:before:ring-2\",\n group: \"flex flex-col gap-4 text-fg\",\n },\n});\n\nconst { group, radio } = radioGroup();\n\ninterface RadioGroupProps extends Omit<AriaRadioGroupProps, \"children\" | \"className\"> {\n className?: string;\n children?: ReactNode;\n label?: string;\n description?: string;\n errorMessage?: string | ((validation: ValidationResult) => string)\n}\n\nconst RadioGroup = ({\n className,\n label,\n description,\n errorMessage,\n children,\n ...props\n}: RadioGroupProps) => (\n <AriaRadioGroup className={group({ className })} {...props}>\n {label}\n {children}\n {description && <Text slot=\"description\">{description}</Text>}\n <FieldError className=\"text-fg-error text-sm\">{errorMessage}</FieldError>\n </AriaRadioGroup>\n);\n\nconst Radio = ({\n children,\n className,\n ...props\n}: RadioProps & {\n className?: string;\n}) => (\n <AriaRadio className={radio({ className })} {...props}>\n {children}\n </AriaRadio>\n);\n\nexport { RadioGroup, Radio }; ", | ||
| "type": "registry:component" | ||
| "content": "\"use client\";\n\nimport type { ReactNode } from \"react\";\n\nimport type {\n RadioGroupProps as AriaRadioGroupProps,\n RadioProps,\n ValidationResult,\n} from \"react-aria-components\";\nimport {\n Radio as AriaRadio,\n RadioGroup as AriaRadioGroup,\n FieldError,\n Text,\n} from \"react-aria-components\";\nimport { tv } from \"tailwind-variants\";\n\nconst radioGroup = tv({\n slots: {\n radio:\n \"flex items-center gap-4 text-fg before:block before:h-5 before:w-5 before:rounded-full before:border before:border-border before:ring-focus before:ring-offset-2 before:ring-offset-surface before:transition-all data-[selected]:before:border-4 data-[selected]:before:border-primary data-[focus-visible]:before:ring-2\",\n group: \"flex flex-col gap-4 text-fg\",\n },\n});\n\nconst { group, radio } = radioGroup();\n\ninterface RadioGroupProps extends Omit<AriaRadioGroupProps, \"children\" | \"className\"> {\n className?: string;\n children?: ReactNode;\n label?: string;\n description?: string;\n errorMessage?: string | ((validation: ValidationResult) => string)\n}\n\nconst RadioGroup = ({\n className,\n label,\n description,\n errorMessage,\n children,\n ...props\n}: RadioGroupProps) => (\n <AriaRadioGroup className={group({ className })} {...props}>\n {label}\n {children}\n {description && <Text slot=\"description\">{description}</Text>}\n <FieldError className=\"text-danger text-sm\">{errorMessage}</FieldError>\n </AriaRadioGroup>\n);\n\nconst Radio = ({\n children,\n className,\n ...props\n}: RadioProps & {\n className?: string;\n}) => (\n <AriaRadio className={radio({ className })} {...props}>\n {children}\n </AriaRadio>\n);\n\nexport { RadioGroup, Radio }; ", |
There was a problem hiding this comment.
Bug: Inconsistent Error Message Styling
The radio-group component's FieldError uses text-fg-error for error messages. This class is undefined in the design system; text-danger is consistently used across other components. Consequently, error messages may not display with the correct styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix target install path