fix(ci): normalize PR state to lowercase in auto-patch (closed-PR guardrail)#67
Merged
Merged
Conversation
gh's REST API returns pull-request state as 'open' / 'closed', GraphQL returns 'OPEN' / 'CLOSED'. The closed-PR guardrail in the composite action and the dev script were comparing against the uppercase form, so the closed-without-merge branch always fired even on open PRs — the action exited with 'is closed without merge' on every run with a 'Client PR:' marker. Normalize the API-returned value via tr to lowercase, then compare to 'open'. Verified against miden-client#2059 (state='open' from REST).
WiktorStarczewski
added
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #65: gh's REST API returns pull-request state as 'open'/'closed' (lowercase), but the action and dev script were comparing against uppercase 'OPEN'. Result: every run with a Client PR: marker triggered the closed-PR guardrail and exited with 'is closed without merge', even on open PRs. Normalize via tr.
Verified against miden-client#2059 (state='open' from REST → was rejecting it; with this fix it's accepted).