fix: add ability to use custom flatlist implementation#170
fix: add ability to use custom flatlist implementation#170arpitv96171 wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
let's revert this? no need to change the bundle of the advanced example editor
| @@ -0,0 +1,57 @@ | |||
| import BottomSheet, { BottomSheetFlatList } from '@gorhom/bottom-sheet'; | |||
There was a problem hiding this comment.
nice ! can we also add it to the doc website? with explanations code snippet and maybe a gif?
| ))} | ||
| </Stack.Navigator> | ||
| </NavigationContainer> | ||
| <GestureHandlerRootView style={homeStyles.root}> |
There was a problem hiding this comment.
why needed? (maybe a dumb question)
There was a problem hiding this comment.
This is the primary setup requirement to ensure react-native-gesture-handler works in the app (which is the dependency of @gorhom/bottom-sheet)
| editor, | ||
| hidden = undefined, | ||
| items = DEFAULT_TOOLBAR_ITEMS, | ||
| ListComponent = FlatList, |
There was a problem hiding this comment.
This is a great ability regardless the bottom-sheet, can we add this to the props table on: https://10play.github.io/10tap-editor/docs/api/Components#toolbar
There was a problem hiding this comment.
@arpitv96171 - first of all thank you very much for that contribution, this is something I was planning to do anyway!
I left some small comments and questions.
would love @17Amir17 to take a look as well
|
@arpitv96171 - commits should follow the commit message convention Same on the other PR both of them all of the commit should start with |
arpitv96171
changed the title
|
new PR #173 |
2 participants
Add ability to use custom Flatlist as component with example
Before: Flatlist does not scroll when used inside bottomsheet
Screen.Recording.2024-07-27.at.22.31.55.mov
After: Using BottomSheetFlatlist which scrolls when used inside @gorhom/bottom-sheet
Screen.Recording.2024-07-27.at.22.32.16.mov