fix: add ability to use custom flatlist implementation#173
Conversation
arpitv96171
force-pushed
the
use-custom-flatlist
branch
from
f090fcf to
dc181bd
Compare
|
updated patch version based on suggestion: #170 (comment) Please let me know if it is to be reverted If this patch version update is to be kept, this PR is to be merged after #172 |
17Amir17
left a comment
17Amir17
left a comment
There was a problem hiding this comment.
Thanks a ton for the pr, however we found some issues that are blocking this
| behavior={Platform.OS === 'ios' ? 'padding' : 'height'} | ||
| style={exampleStyles.keyboardAvoidingView} | ||
| > | ||
| <Toolbar editor={editor} ListComponent={BottomSheetFlatList} /> |
There was a problem hiding this comment.
On IOS the toolbar is not visible
On android we are unable to scroll inside the text editor
Screen.Recording.2024-07-29.at.14.16.59.mov
There was a problem hiding this comment.
@17Amir17 I have updated the PR. You can re-review it.
iOS:
Screen.Recording.2024-08-01.at.00.11.29.mov
Android:
Screen.Recording.2024-08-01.at.00.12.12.mov
17Amir17
left a comment
17Amir17
left a comment
There was a problem hiding this comment.
Thanks for updating - unfortunately I still see a few issues
When testing I got a bunch of these warnings:
WARN [Reanimated] Tried to modify key `reduceMotion` of an object which has been already passed to a worklet. See
https://docs.swmansion.com/react-native-reanimated/docs/guides/troubleshooting#tried-to-modify-key-of-an-object-which-has-been-converted-to-a-shareable
for more details.
| } from 'react-native'; | ||
| import { RichText, Toolbar, useEditorBridge } from '@10play/tentap-editor'; | ||
|
|
||
| const useKeyboard = () => { |
There was a problem hiding this comment.
You should be able to import this from @10play/tentap-editor
| return keyboardHeight; | ||
| }; | ||
|
|
||
| export const WithBottomSheet = ({}: NativeStackScreenProps<any, any, any>) => { |
There was a problem hiding this comment.
I am still unable to scroll on Android - seems like the scroll is getting handled by the drawer
Screen.Recording.2024-08-04.at.14.31.44.mov
2 participants
Add ability to use custom Flatlist as component with example
Before: Flatlist does not scroll when used inside bottomsheet
Screen.Recording.2024-07-27.at.22.31.55.mov
After: Using BottomSheetFlatlist which scrolls when used inside @gorhom/bottom-sheet
Screen.Recording.2024-07-27.at.22.32.16.mov