Add support to build MOM5 with an external FMS and Generic Tracers using Spack#29
Closed
Add support to build MOM5 with an external FMS and Generic Tracers using Spack#29
Conversation
Author
|
FYI, I decided not to include this commit in this PR for the sake of simplicity: |
aidanheerdegen
suggested changes
Nov 27, 2024
Member
aidanheerdegen
left a comment
There was a problem hiding this comment.
Line 150 sets lib_include_dirs which is used in all the component build scripts
set lib_include_dirs = "$root/include $code_dir/shared/include $code_dir/shared/mpp/include"
I think it should also be bracketed with logic to test for external FMS.
a90562b to
c662cd5
Compare
Collaborator
|
What's holding up getting this merged @harshula? Is it just waiting for final review/approval? |
Author
|
Hi @dougiesquire , Originally it was a hack in-order to test the generic tracers. I'm not happy with the changes that I made. Can you and @aidanheerdegen work on this and come up with a neater solution? I'll drop my commits in the development branch. |
8829396 to
3e42512
Compare
Author
|
This PR is superseded by PR #39 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
least intrusive and simple way to introduce this feature.