IS-05: Testing scenario when two receivers get bulk-staged for relati…#73
IS-05: Testing scenario when two receivers get bulk-staged for relati…#73bakaleks wants to merge 1 commit intoAMWA-TV:masterfrom
Conversation
…ve scheduled activation. Both of them should be activated. Testing with Sony's nmos-cpp-node sample application with two registered receivers
|
Testing with following change sony/nmos-cpp#43 |
garethsb
left a comment
There was a problem hiding this comment.
Thanks, @bakaleks. I think this will be a great addition to the test suite - it demonstrated a bug in my implementation as you said.
I'd like to see a bit of refactoring to eliminate the duplication with IS05Utils.check_perform_relative_activation if possible. What do you think, @andrewbonney?
|
I'll ask @simonrankine to take a quick scan. Otherwise as this is your first contribution @bakaleks we'll probably have to ask you to fill in an IPR form as-per point 3 in https://github.com/AMWA-TV/nmos-testing/blob/master/CONTRIBUTING.pdf. It might be easiest for us to discuss in person next week. |
|
Over-all this looks like a good and useful thing to have in the test suite, thanks very much for your contribution. What I would say is that there seems to be a lot with duplication with check_bulk_stage in the same file, to the point where I think I'd like it to be combined with check_bulk_active_relative before we merge, or this code is going to get mighty hard to maintain. |
…ve scheduled activation. Both of them should be activated. Testing with Sony's nmos-cpp-node sample application with two registered receivers