In the example node app when looping through the staged resources, co…#43
Closed
bakaleks wants to merge 1 commit intosony:masterfrom
Closed
In the example node app when looping through the staged resources, co…#43bakaleks wants to merge 1 commit intosony:masterfrom
bakaleks wants to merge 1 commit intosony:masterfrom
Conversation
…nnection_resource iterator gets modified by nmos::modify_resource() while iterating. That results in an unpredictable behaviour when bulk-staging several activations and not all changes get activated. This is only triggered when several receivers(possibly senders too) are registered within the node. This fix proposes copying iterator elements into a separate vector beforehand. Reproducable by leaving out iterator-copying and running AMWA's nmos-testing IS05, test_41 (separate pull request in progress there).
Author
|
Created new test for this AMWA-TV/nmos-testing#73 |
Contributor
|
Thank you for the report and proposed fix. I think it should be possible to solve this without the need to copy whole resources or even iterators to resources by tweaking the iteration instead. I'm going to investigate this locally; hopefully will push a fix later today. |
Contributor
|
Hi @bakaleks I believe this is resolved by 7f1823c. Thanks again for the detailed bug report, investigation and test case - I'll add a review of AMWA-TV/nmos-testing#73 soon as well. See you in Newbury next week! |
Author
|
Thanks Gareth! Great stuff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nnection_resource iterator gets modified by nmos::modify_resource() while iterating. That results in an unpredictable behaviour when bulk-staging several activations and not all changes get activated. This is only triggered when several receivers(possibly senders too) are registered within the node.
This fix proposes copying iterator elements into a separate vector beforehand.
Reproducable by leaving out iterator-copying and running AMWA's nmos-testing IS05, test_41 (separate pull request in progress there).