Add explicit unsupported-format guards for TLE ingest#1316
Open
ReeceHumphreys wants to merge 3 commits intodevelopfrom
Open
Add explicit unsupported-format guards for TLE ingest#1316ReeceHumphreys wants to merge 3 commits intodevelopfrom
ReeceHumphreys wants to merge 3 commits intodevelopfrom
Conversation
ReeceHumphreys
force-pushed
the
feature/fix-tle
branch
from
65e5dc2 to
05e3317
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR now adds validation checks on TLE's to check that they are the numeric 5 digit catalogue type. Else rejects them and raises errors. Previously we would have silently tried to parse these and ran into issues.
Verification
Added new tests to check each of the validation criteria.
Documentation
N/A
Future work
We could potentially add support for the 6 digit cat Ids and the 5 digit alpha numeric catalogue ids.