remove deprecated multiSphereVector swig interface#1322
Merged
Conversation
andrewmorell
approved these changes
Mar 11, 2026
Contributor
andrewmorell
left a comment
andrewmorell
left a comment
There was a problem hiding this comment.
Looks good! Out of curiosity would it not make sense in the future to combine those two release notes snippets into one snippet, or are you wanting to credit different tickets?
schaubh
force-pushed
the
feature/remove__MultiSphereVector
branch
from
9ba3176 to
f93557e
Compare
Contributor
Author
|
I could have combined them. I did the fixes in two steps and ended up with two notes. Once I push BSK v2.10.0 this all goes away anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch completes removal of long-deprecated
MultiSphere*compatibility usage in Vizard SWIG bindings and cleanup in examples/docs.Changes included:
mod.MultiSphereVectoralias wrapper fromsrc/simulation/vizard/vizInterface/vizInterface.i.mod.MultiSphereandmod.MultiSphereInfoalias wrappers fromsrc/simulation/vizard/vizInterface/vizInterface.i.examples/scenarioDebrisReorbitET.py.src/architecture/_GeneralModuleFiles/swig_deprecated.i.docs/source/Support/bskReleaseNotesSnippets/1320-remove-multispherevector-alias.rstdocs/source/Support/bskReleaseNotesSnippets/1321-remove-multisphere-aliases.rstVerification
Validated with targeted automated test:
.venv/bin/pytest -q src/tests/test_scenarioDebrisReorbitET.py1 passed in 2.23sReference checks:
MultiSphereVectorusage.mod.MultiSphere = _DeprecatedWrapperormod.MultiSphereInfo = _DeprecatedWrapper.MultiSphereVectornow appears only in release-note snippet text.No tests were added/updated because this PR removes deprecated compatibility paths and does not introduce new functional behavior.
Documentation
Documentation updates in this PR:
docs/source/Support/bskReleaseNotesSnippets/(per Basilisk PR policy).swig_deprecated.iusage example text to avoid referencing removed aliases.No direct edit was made to
docs/source/Support/bskReleaseNotes.rst.Future work
None