build(frontend): vue-router 5.1 + vite 8.0 against dev; dependabot target-branch fix (supersedes #1015)#1133
Open
vybe wants to merge 2 commits into
Open
build(frontend): vue-router 5.1 + vite 8.0 against dev; dependabot target-branch fix (supersedes #1015)#1133vybe wants to merge 2 commits into
vybe wants to merge 2 commits into
Conversation
…return-style Rebuilds dependabot PR #1015 (+ dolho's vite-8 fold-in of #1063) against dev — the original targeted main, but dev's router/index.js was restructured by #1109 (Operations consolidation) and still carried 11 next()-callback guard sites, guaranteeing a conflict at the next release cut. - vue-router ^5.1.0: migrate beforeEach + AgentWorkspace beforeEnter from the deprecated next() callback to return-style (true = proceed, location = redirect). All 11 sites converted; behavior preserved. - vite ^8.0.16 (rolldown): production build verified in node:20-alpine (matches docker/frontend images, Node 20.20 ≥ vite 8's 20.19 floor). - package-lock.json regenerated in a clean container. Supersedes #1015. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Dependabot was opening PRs against the default branch (main) while all feature work merges to dev, so merged bumps accumulated on main only (e.g. axios ^1.17.0 on main vs ^1.16.1 on dev) and conflicted with dev at every release cut. target-branch: dev on all five ecosystems routes bumps through the normal dev → main release path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vybe
added
frontend
This was referenced Jun 10, 2026
|
Resolve by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds dependabot PR #1015 (vue-router 4.6.3 → 5.1.0, plus the Vite 6.4 → 8.0.16 fold-in of #1063) against
dev. The original targetedmain, butdev'srouter/index.jswas restructured by #1109 (Operations consolidation) and still carried 11next()-callback guard sites — merging #1015 tomainwould have guaranteed a conflict (or a wrong-side resolution) at the next release cut.Changes
src/frontend/src/router/index.js— migrate the globalbeforeEachand the AgentWorkspacebeforeEnterfrom the deprecatednext()callback to Vue Router 5 return-style guards (true= proceed, location = redirect). All 11 sites converted on dev's refactor(ui): unify Health + Ops + Executions into a single Operations nav area #1109-restructured file; redirect logic byte-for-byte equivalent.src/frontend/package.json—vue-router ^5.1.0,vite ^8.0.16(only these two lines; dev's other pins untouched).src/frontend/package-lock.json— regenerated in a cleannode:20-alpinecontainer..github/dependabot.yml—target-branch: devon all five ecosystems. Dependabot's default (repo default branch =main) was creating main-side drift: bumps landed onmainwhile features landed ondev(e.g. axios^1.17.0on main vs^1.16.1on dev). All dep PRs now flow through the normaldev → mainrelease path.Verification
npm run build(Vite 8 / rolldown) green innode:20-alpine— same base as bothdocker/frontendDockerfiles; Node 20.20 satisfies Vite 8's ≥20.19 floor. Full app builds in ~2s.vite 8.0.16/vue-router 5.1.0/vue 3.5.35/@vitejs/plugin-vue 6.0.7.grep -n 'next(' router/index.js→ zero remaining callback-style sites.uilabel applied sofrontend-e2eruns on this PR (it was SKIPPED on chore(deps): bump vue-router from 4.6.3 to 5.1.0 in /src/frontend #1015 — a router-major shipped with no browser-level verification).Supersedes #1015. Related: #1063, #1109.
🤖 Generated with Claude Code