Fix JavaScript function declaration syntax in iframe template#36
Merged
MikeVerlinde merged 2 commits intomasterfrom Apr 22, 2026
Merged
Fix JavaScript function declaration syntax in iframe template#36MikeVerlinde merged 2 commits intomasterfrom
MikeVerlinde merged 2 commits intomasterfrom
Conversation
Without the trailing semicolons, HTML minification collapses the inline <script> into a single line where `}window.tagging_gtm_advanced_hash` breaks JS parsing with a syntax error. https://claude.ai/code/session_01UA52TPmLooaznkU249WJze
MikeVerlinde
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects JavaScript syntax errors in the iframe template by converting function declarations to proper function expressions with semicolons.
Key Changes
window.tagging_gtm_simple_hash = function(eventData) { ... }to end with};instead of}window.tagging_gtm_advanced_hash = function(eventData) { ... }to end with};instead of}window.tagging_gtm_save_hash = function(hash, marketingObject) { ... }to end with};instead of}Implementation Details
These changes ensure proper JavaScript syntax for function expressions assigned to window objects. Function expressions should be terminated with a semicolon, following JavaScript best practices and linting standards. This prevents potential syntax errors and improves code consistency across the codebase.
https://claude.ai/code/session_01UA52TPmLooaznkU249WJze