Skip to content

Fix JavaScript function declaration syntax in iframe template #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeVerlinde merged 2 commits into from
Apr 22, 2026
+4 −4
Merged

Fix JavaScript function declaration syntax in iframe template #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12f8fc3
Terminate hash function expressions with semicolons
claude Apr 22, 2026
c049050
build: bump version
MikeVerlinde Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "tagginggroup/gtm",
"version": "1.5.6",
"version": "1.5.7",
"license": "OSL-3.0",
"type": "magento2-module",
"description": "AdPage tagging integration for Magento 2",
Expand Down
6 changes: 3 additions & 3 deletions view/frontend/templates/iframe.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ window.tagging_gtm_simple_hash = function(eventData) {

const value = parts.join("&");
return btoa(value);
}
};

/**
* Generate advanced hash based on items, quantities, and user agent
Expand All @@ -76,7 +76,7 @@ window.tagging_gtm_advanced_hash = function(eventData) {

const value = parts.join("&");
return btoa(value);
}
};

window.tagging_gtm_save_hash = function(hash, marketingObject) {
if (!hash || !marketingObject) {
Expand All @@ -99,7 +99,7 @@ window.tagging_gtm_save_hash = function(hash, marketingObject) {
.catch((err) => {
console.error(`Error sending data to API`, err);
});
}';
};';

if ($isHyva): ?>
<script><?= $mainScript ?></script><?php $hyvaCsp->registerInlineScript() ?>
Expand Down
Loading