feat!: ist winddown#401
Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
| "type": "module", | ||
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "export NODE_OPTIONS='--max-old-space-size=8192' && tsc && vite build", |
There was a problem hiding this comment.
why drop tsc? does vite build do typecheck?
either way, I suppose it belongs in lint like in our other packages. you could put it first since it's the fastest and most likely to find a bug
There was a problem hiding this comment.
Added a lint:types with a warning
| "@agoric/casting": "^0.4.3-u13.0", | ||
| "@agoric/cosmic-proto": "^0.3.0", | ||
| "@agoric/ertp": "^0.16.2", | ||
| "@agoric/ertp": "^0.16.3-u20.0", |
There was a problem hiding this comment.
if some of these are u20, shouldn't they all be? to avoid duplicates and bundle bloat
There was a problem hiding this comment.
I probably shouldn't have upgraded this to u20, it was unnecessary and I was just confused by typescript errors and red squiggilies in my IDE
| import { | ||
| floorMultiplyBy, | ||
| ratioGTE, | ||
| } from '@agoric/zoe/src/contractSupport/ratio'; | ||
| } from '@agoric/zoe/src/contractSupport/index'; |
There was a problem hiding this comment.
this is in ERTP now. you might not need @agoric/zoe anymore
| import { | |
| floorMultiplyBy, | |
| ratioGTE, | |
| } from '@agoric/zoe/src/contractSupport/ratio'; | |
| } from '@agoric/zoe/src/contractSupport/index'; | |
| import { floorMultiplyBy, ratioGTE } from '@agoric/ertp/src/ratio.js'; |
There was a problem hiding this comment.
Reverted to older version of ertp so this won't be included
| import { AmountMath } from '@agoric/ertp'; | ||
| import type { Amount, NatValue } from '@agoric/ertp/src/types'; | ||
| import { ratioGTE } from '@agoric/zoe/src/contractSupport/index'; | ||
| import { AmountMath } from '@agoric/ertp/src/index'; |
There was a problem hiding this comment.
It did, thanks, fixed
| jsesc "^2.5.1" | ||
| source-map "^0.5.0" | ||
|
|
||
| "@agoric/base-zone@^0.1.1-u20.0": |
There was a problem hiding this comment.
this file got much larger but shouldn't. please adjust the versions. you could use * for '@endo/' versions so that the agoric deps imply them. the agoric deps should also be linked up to a tag like u20.
There was a problem hiding this comment.
Just used * for '@endo/' versions
Deploying dapp-inter-test with
|
| Latest commit: |
b1eedd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fd35b90.dapp-inter-test.pages.dev |
| Branch Preview URL: | https://ist-winddown.dapp-inter-test.pages.dev |
Deploying agoric-dapp-inter-emerynet with
|
| Latest commit: |
b1eedd8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb2dc885.agoric-dapp-inter-emerynet.pages.dev |
| Branch Preview URL: | https://ist-winddown.agoric-dapp-inter-emerynet.pages.dev |
| "dev": "vite", | ||
| "build": "export NODE_OPTIONS='--max-old-space-size=8192' && vite build", | ||
| "preview": "vite preview", | ||
| "lint:types": "echo 'XXX tsc is not working, even though vite build is successful' && tsc --noEmit", |
| makeRatioFromAmounts, | ||
| } from '@agoric/zoe/src/contractSupport'; | ||
| multiplyBy, | ||
| } from '@agoric/zoe/src/contractSupport/ratio'; |
There was a problem hiding this comment.
these are all in @agoric/ertp now. since this app is going away I won't push for it
2 participants
Just updates @agoric/web-components and fixes type errors so it builds. This will cause it to use BLD as the fee token in the wallet connection. We don't need to mess with the smart wallet provision flow because the mint limits are 0 so that code path shouldn't happen.
Related: Agoric/dapp-psm#175