feat!: ist winddown#175
Conversation
Deploying dapp-psm with
|
| Latest commit: |
77e9ee8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87e75c97.dapp-psm.pages.dev |
| Branch Preview URL: | https://ist-winddown.dapp-psm.pages.dev |
| "scripts": { | ||
| "dev": "vite", | ||
| "build": "tsc && vite build", | ||
| "build": "vite build", |
There was a problem hiding this comment.
Removes the "tsc" step in build because vite already compiles it and I got an error in node_modules when upgrading @agoric/web-components https://gist.github.com/samsiegart/7794b51ef6875a14fc5521a53bf9fdb0
Thanks for explaining this. In the other PR I asked for tsc to be in lint. I won't ask that here. I thought of asking that the reason for omission be mentioned in the README but maybe by the time someone tries to add tsc back it won't have problems. If it does they won't have wasted much time finding out.
There was a problem hiding this comment.
I added a yarn lint:types with a warning. My standpoint is that this would take some effort to debug here and in Agoric/dapp-inter#401 and these apps are going to be shut down soon anyway
| ({ key }: { key: string }) => key === 'feeUnit' | ||
| )?.beans; | ||
| const feeUnitName = params.params?.feeUnitPrice[0]?.denom; | ||
| assert(feeUnit); |
There was a problem hiding this comment.
consider an error message. also they all need to be present (if they aren't the BigInt will make 0n)
| assert(feeUnit); | |
| assert(beansPerSmartWallet && feeUnit && feeUnitName, 'missing fee params'); |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
2 participants
Changes the provision smart wallet notice / onboard ist modal to support bld as well when it's set as the swingset fee.
Upgrades @agoric/web-components which now uses BLD only as the fee token for the wallet connection.
Removes the "tsc" step in build because vite already compiles it and I got an error in node_modules when upgrading @agoric/web-components https://gist.github.com/samsiegart/7794b51ef6875a14fc5521a53bf9fdb0