Skip to content

Always remove extract-css-loader on server#191

Open
bogdantica wants to merge 2 commits into
Akryum:masterfrom
bogdantica:master
Open

Always remove extract-css-loader on server#191
bogdantica wants to merge 2 commits into
Akryum:masterfrom
bogdantica:master

Conversation

@bogdantica

Copy link
Copy Markdown

... even when cricitcalCSS is disabled. This fixes the document is not defined bug in production mode
Fixes #186

phil294 and others added 2 commits March 23, 2020 13:25
... even when `cricitcalCSS` is disabled. This fixes the `document is not defined` bug in production mode
Fixes Akryum#186
@sneko

sneko commented Jun 28, 2020

Copy link
Copy Markdown

Interested to have this merged 👍

@sneko

sneko commented Jul 8, 2020

Copy link
Copy Markdown

Just decided to use my own fork with v0.6.0.

I did it be aliasing this repo:

yarn add "@akryum/vue-cli-plugin-ssr@https://github.com/sneko/vue-cli-plugin-ssr#fix/disabling-criticalcss"

I really hope in the future all critical PR will be merged, it's a great SSR plugin but it comes with too many breaks 😢

sneko added a commit to sneko/vue-cli-plugin-ssr that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"document is not defined" when criticalCSS is disabled in production

3 participants