Improve xchr function(AlphaGenes/AlphaPeel#225)#226
Open
AprilYUZhang wants to merge 11 commits intoAlphaGenes:develfrom
Open
Improve xchr function(AlphaGenes/AlphaPeel#225)#226AprilYUZhang wants to merge 11 commits intoAlphaGenes:develfrom
AprilYUZhang wants to merge 11 commits intoAlphaGenes:develfrom
Conversation
Devel work from @XingerTang @AprilYUZhang and @RosCraddock and me!
Member
|
@AprilYUZhang how do these changes impact the example results - can you share like I did at #199 (comment)? |
AprilYUZhang
commented
Mar 17, 2026
AprilYUZhang
commented
Mar 17, 2026
This was referenced Mar 17, 2026
Contributor
|
Hi @AprilYUZhang, can you provide a tinyhouse reference that this code can run with? |
Contributor
Author
|
e8a7cd3e12378941e2aef5a05ff161eb49204a9f |
…rove-xchr-function Merge latest devel branch
Contributor
Author
|
I have merged the latest devel branch, and it works. |
tests/accuracy_tests/sim_for_alphapeel_accu_test/sim_for_sex_chr_accu.R
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Have done. |
Contributor
|
All looks good to me! @AprilYUZhang, can you squash some commits, or do you prefer to merge directly? |
Member
|
Best to squash commits if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Relate to #225
What changed
Why this change
See #199 #216 #217
Notes / Risks
For x chr, the default seg probs are changed.