test(embeddedch): raise start timeout 60s→120s to de-flake CI#145
Open
BorisTyshkevich wants to merge 1 commit into
Open
test(embeddedch): raise start timeout 60s→120s to de-flake CI#145BorisTyshkevich wants to merge 1 commit into
BorisTyshkevich wants to merge 1 commit into
Conversation
The embedded-ClickHouse Start() intermittently timed out at 60s in CI (e.g. the v1.6.0 release build), where the suite runs `-parallel 4 -shuffle` and up to four real CH servers start concurrently on a cold runner still extracting the downloaded binary. 120s absorbs the contention; a genuinely bad config fails fast with a CH error, so this won't mask real startup failures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded-ClickHouse
Start()intermittently times out at 60s in CI — it caused the v1.6.0 release build to fail (TestEmbeddedClickHouseXMLDropIn,embeddedch.go:152).Cause: CI runs the suite with
-parallel 4 -shuffle, so up to four real ClickHouse servers start concurrently on a cold runner that may also still be extracting the downloaded binary. 60s is too tight under that contention.Fix: raise the default
StartTimeoutto 120s. A genuinely bad config still fails fast with a CH error, so this absorbs the timing flake without masking real startup failures. Pre-existing test/harness — no behavior change to the product.🤖 Generated with Claude Code