Skip to content

test(embeddedch): raise start timeout 60s→120s to de-flake CI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BorisTyshkevich wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

test(embeddedch): raise start timeout 60s→120s to de-flake CI #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions internal/testutil/embeddedch/embeddedch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func WithTCPProtocol() Option {
return func(o *Options) { o.Protocol = config.TCPProtocol }
}

// WithStartTimeout overrides the default 60s start timeout.
// WithStartTimeout overrides the default 120s start timeout.
func WithStartTimeout(d time.Duration) Option {
return func(o *Options) { o.StartTimeout = d }
}
Expand All @@ -105,8 +105,13 @@ func Setup(t *testing.T, opts ...Option) *config.ClickHouseConfig {
}

o := Options{
Protocol: config.HTTPProtocol,
StartTimeout: 60 * time.Second,
Protocol: config.HTTPProtocol,
// 120s, not 60s: CI runs the suite with `-parallel 4 -shuffle`, so up to
// four real ClickHouse servers start concurrently on a cold runner that
// may also still be extracting the downloaded binary. 60s intermittently
// timed out at Start() (flaky release-build failures); 120s absorbs the
// contention without masking a genuine startup error (those fail fast).
StartTimeout: 120 * time.Second,
}
for _, fn := range opts {
fn(&o)
Expand Down